Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #2049: ImageSource loading error message #2052

Merged
merged 1 commit into from
Oct 4, 2021
Merged

fix #2049: ImageSource loading error message #2052

merged 1 commit into from
Oct 4, 2021

Conversation

nidble
Copy link
Contributor

@nidble nidble commented Oct 4, 2021

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #2049

Changes:

  • Improve ImageSource error with specific information
  • Wrap the previous error object, with a generic Error to enhance error handling
  • Provide a syntax more lightweight when dealing with error propagation
  • Add new test case

eonarheim
eonarheim approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@eonarheim eonarheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nidble Great work! This is fantastic

@eonarheim eonarheim merged commit b7ba8fe into excaliburjs:main Oct 4, 2021
@nidble nidble deleted the fix/imageSource-loading-error-message-2049 branch October 4, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eonarheim eonarheim eonarheim approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix ImageSource loading error message
2 participants
@nidble @eonarheim