Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [#1892] Animations should allow you to specify the total duration #2065

Conversation

catrielmuller
Copy link
Contributor

Total Duration implementation on ex.Animation

  • Added a Storybook to check the behavior visually of the frameDuration property
  • Added a Storybook to check the behavior visually of the totalDuration property
  • Included the test to validate this new functionality

Lmk if you consider that this need a change.
Cheers

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #1892 -

Changes:

  • ex.Animation now support totalDuration that will calculate automatically each frame duration based on how many frames have.

@catrielmuller catrielmuller force-pushed the catriel/1892-animation-total-duration branch from cd516c7 to 12d4f4f Compare October 23, 2021 04:10
… each frame duration based on how many frames have.
@catrielmuller catrielmuller force-pushed the catriel/1892-animation-total-duration branch from 12d4f4f to 728d8af Compare October 23, 2021 04:12
Copy link
Member

@eonarheim eonarheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@catrielmuller Thanks for the contribution! Good test and thanks for adding some stories!

@eonarheim eonarheim changed the title Animations should allow you to specify the total duration feat: [#1892] Animations should allow you to specify the total duration Oct 23, 2021
@eonarheim eonarheim merged commit 0905c4e into excaliburjs:main Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animations should allow you to specify the total duration
2 participants