Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#2076] Defer initialization until after final resolution calculated #2093

Merged
merged 7 commits into from
Nov 6, 2021
Merged

fix: [#2076] Defer initialization until after final resolution calculated #2093

merged 7 commits into from
Nov 6, 2021

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Nov 2, 2021 •
edited
Loading

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

TODO:

  • WebGL will silently fail at high resolutions which is easy to get to with hidpi scaling
  • Warn when l.drawingBufferHeight/l.drawingBufferWidth don't match height/width
  • Documentation improvement for original issue for different displaymodes
  • Fix tests

Closes #2076

Changes:

  • Deferred initialization of scene/camera until final resolution is calculated

@eonarheim
fix: [#2076] Defer initialization until after final resolution calcul…
684ebac 
…ated

TODO:
* [ ] WebGL will silently fail at high resolutions which is easy to get to with hidpi scaling
* [ ] Warn when l.drawingBufferHeight/l.drawingBufferWidth don't match height/width
* [ ] Fix tests
@eonarheim eonarheim added the work-in-progress A work in progress pull request, will not be merged until this is removed label Nov 2, 2021
@eonarheim eonarheim removed the work-in-progress A work in progress pull request, will not be merged until this is removed label Nov 6, 2021
@eonarheim eonarheim merged commit e603adb into main Nov 6, 2021
@eonarheim eonarheim deleted the bugfix/2076-camera-init-hidpi branch November 6, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedeen jedeen jedeen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DisplayMode.FitScreen is just … weird
2 participants
@eonarheim @jedeen