Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Remove .call() in EventDispatcher #2103

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

nidble
Copy link
Contributor

@nidble nidble commented Nov 10, 2021

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #2047

Changes:

  • EventDispatcher - doesn't require the target object. The context of this is not tampered anymore.
  • PointerAbstraction - is fixed to maintain reference
  • The following Engine's pieces: Collision Graphics Resources Trigger are updated to accomodate the new EventDispatcher behavior.

@nidble nidble changed the title Refactor: Remove .call() in EventDispatcher (#2047) Refactor: Remove .call() in EventDispatcher Nov 10, 2021
Copy link
Member

@eonarheim eonarheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nidble Thanks for the contribution! This is great!

@eonarheim
Copy link
Member

I threw the hacktoberfest label on there, not positive they are still counting PRs, worth a shot 👍

@eonarheim eonarheim merged commit ba20717 into excaliburjs:main Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove .call() in EventDispatcher
2 participants