Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#1815] TileMap tiling artifact #2146

Merged
merged 17 commits into from
Dec 23, 2021
Merged

fix: [#1815] TileMap tiling artifact #2146

merged 17 commits into from
Dec 23, 2021

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Dec 4, 2021

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Accidentally Closes #1815

Fix tiling artifact that can appear in standard dpi screens, this is caused by seams in the geometry that may not fall on an actual screen pixel causing a visible gap between the tiles to the background

image

The solution is to remove unnecessary scaling in the graphics pipeline, a UV bodge factor to keep the pixels from bleeding to the next texture in power of 2, and optimizing the camera update and positioning.

Changes:

TODO before merge

  • Tests
  • Code cleanup (avoid passing engine down to the renderer)

@eonarheim eonarheim merged commit 90c1fd7 into main Dec 23, 2021
@eonarheim eonarheim deleted the bugfix/tilemap-artifact branch December 23, 2021 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lockToActor jitter on large velocities — Camera.update() should be called onPostUpdate
1 participant