Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#2192] Actor.center returns global position #2193

Merged
merged 3 commits into from
Jan 13, 2022

Conversation

eonarheim
Copy link
Member

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #2192

Changes:

  • Adds a new property Actor.localCenter to retrieve the center in local coordinates
  • Updates the Actor.center property to use the global position from the TransformComponent

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Jan 13, 2022
@eonarheim eonarheim merged commit bf8e592 into main Jan 13, 2022
@eonarheim eonarheim deleted the fix/2192-center-not-global branch January 13, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Center of child not updated on parent move. Breaks camera strategies.
1 participant