Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2263 keyboard wasPressed works in onPostUpdate lifecycle #2270

Merged
merged 2 commits into from
Mar 12, 2022

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Mar 9, 2022

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #2263

This PR adjusts the keyboard & gamepad input updates to the actual end of the frame after the onPostUpdate lifecycle. Additionally this adds a number of missing key codes in the ex.Input.Keys enum.

@eonarheim eonarheim added the work-in-progress A work in progress pull request, will not be merged until this is removed label Mar 9, 2022
@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Mar 9, 2022
@eonarheim eonarheim removed the work-in-progress A work in progress pull request, will not be merged until this is removed label Mar 12, 2022
@eonarheim eonarheim merged commit 0142834 into main Mar 12, 2022
@eonarheim eonarheim deleted the fix/enter-key branch March 12, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Enter key in enum Keys
1 participant