Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(motion): Improve capture transform perf #2278

Merged
merged 5 commits into from
Apr 9, 2022

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Mar 19, 2022

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Improve the transform capture perf by copying the current transform into a held matrix. The old way forced the matrix to perform unnecessary calculations when setting individual aspects of the matrix

Benchmarks on Surface Book II

Left current main, right new changes. We see several frame improvement in the 2000 and 4000 cases!

2000 Actors AVG FPS 54 -> 59
image

4000 Actors AVG FPS 30 -> 37
image

@github-actions github-actions bot added the enhancement Label applied to enhancements or improvements to existing features label Mar 19, 2022
@eonarheim eonarheim merged commit 46f8ea9 into main Apr 9, 2022
@eonarheim eonarheim deleted the feature/capture-transform-perf branch April 9, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Label applied to enhancements or improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant