Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphics): Large Text segments render properly by breaking them into smaller pieces #2295

Merged
merged 9 commits into from
Apr 14, 2022

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Apr 12, 2022

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #2290

This PR adds some additional logic into the text rendering code of Font that breaks the underlying text raster into separate < 4k sized chunks that will work on mobile platforms.

image

Changes:

  • Adds a TextureLoader.delete(imageSource) method for cleaning up old GPU textures

@eonarheim eonarheim changed the title fix(Graphics): Large Text segments render properly by breaking them into smaller pieces fix(graphics): Large Text segments render properly by breaking them into smaller pieces Apr 12, 2022
@eonarheim eonarheim merged commit 2faa42f into main Apr 14, 2022
@eonarheim eonarheim deleted the bugfix/text-too-large branch April 14, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text Graphics can easily get too large for the mobile limit (4k)
1 participant