-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Oscillation issue with pixel snapping + pixelToSnap
default false
#2348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
This issue describes undesirable, incorrect, or unexpected behavior
label
Jun 12, 2022
eonarheim
changed the title
fix: Fix oscillation issue with pixel snapping
fix: Oscillation issue with pixel snapping
Jun 14, 2022
…fix/tweak-pixel-snapping
…fix/tweak-pixel-snapping
…fix/tweak-pixel-snapping
eonarheim
changed the title
fix: Oscillation issue with pixel snapping
fix: Oscillation issue with pixel snapping + Jul 2, 2022
pixelToSnap
default false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
===:clipboard: PR Checklist :clipboard:===
==================
This PR fixes an issue that could cause graphical oscillations to occur when near a pixel boundary. To fix this we add a small epsilon to the pixel snap to nudge pixels over a boundary.
This PR also switches the default
snapToPixel
default back tofalse