-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [#2359] work around image decode limits in chromium #2361
Conversation
@eonarheim I just did some checks and noticed one not very cool thing. In my case with this error, Image#decode was fired only 20 times. |
@HxShard Good call out, I'll do some experimentation to see how the buffer size plays into this. Roughly how large were your images? Dimensions and disk size? |
@eonarheim https://gist.github.com/HxShard/376b82855f076e4f6e8b51fc40e85f7e |
@HxShard With some experimentation, looks like using I checked using the old school I'm going to explore removing the semaphore and switching to the |
===:clipboard: PR Checklist :clipboard:===
==================
Closes #2359
This PR switches away from
Image.decode()
to use the older method ofImage.onload
this method is more reliable for large or numerous images due to a chromium bug around decode.@HxShard provided a great codesandbox illustrating the issue https://codesandbox.io/s/happy-gagarin-j1vjr
Changes:
enter
andexit