fix: [#2409] engine 'visible' event not firing #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eonarheim
requested changes
Jul 14, 2022
There was a problem hiding this comment.
@mattjennings Looks great!
Just needs some lint clean up
npm run eslint -- --fix && npm run eslint:spec -- --fix
|
oops! should be good now |
eonarheim
approved these changes
Jul 15, 2022
|
@mattjennings Thanks again for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
engine.on('visible')not firing by usingdocument.visibilityStateAPI to determine current state===:clipboard: PR Checklist :clipboard:===
==================
Closes #2409
Changes:
engine.on('visible')event not firing