Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#2411] Prevent font corruption with separate state container #2413

Merged
merged 10 commits into from
Jul 16, 2022
Merged

fix: [#2411] Prevent font corruption with separate state container #2413

merged 10 commits into from
Jul 16, 2022

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Jul 14, 2022 •
edited
Loading

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #2411

Changes:

  • Refactor font to be simpler and use a separate state container for each text instance

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Jul 14, 2022
@eonarheim eonarheim merged commit 730d621 into main Jul 16, 2022
@eonarheim eonarheim deleted the fix/2411-font-corruption branch July 16, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple Text objects using the same Font object overwrite each other
1 participant
@eonarheim