Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#2407] Repair ex.Actor.clone() #2414

Merged
merged 9 commits into from
Feb 11, 2023
Merged

fix: [#2407] Repair ex.Actor.clone() #2414

merged 9 commits into from
Feb 11, 2023

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Jul 14, 2022 •
edited
Loading

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #2407

Changes:

  • Adds specific clone methods for various components to support a new ex.Actor.clone()

TODO

  • Implement specific clone methods for excalibur component types

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Jul 14, 2022
@github-actions
Copy link

github-actions bot commented Oct 7, 2022

This PR hasn't had any recent activity lately and is being marked as stale automatically.

@github-actions github-actions bot added the stale This issue or PR has not had any activity recently label Oct 7, 2022
@eonarheim eonarheim removed the stale This issue or PR has not had any activity recently label Jan 28, 2023
@eonarheim eonarheim merged commit 017953a into main Feb 11, 2023
@eonarheim eonarheim deleted the fix/2407-clone-throws branch February 11, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Actor clone method throws error
1 participant
@eonarheim