Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#2418] falsey event values being converted to GameEvent #2422

Merged
merged 1 commit into from
Jul 17, 2022
Merged

fix: [#2418] falsey event values being converted to GameEvent #2422

merged 1 commit into from
Jul 17, 2022

Conversation

mattjennings
Copy link
Contributor

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #2418

Changes:

  • Fixed EventDispatcher.emit converting falsy values to ex.GameEvent. It will only convert undefined or null values now.

@eonarheim eonarheim merged commit 245426d into excaliburjs:main Jul 17, 2022
@eonarheim
Copy link
Member

@mattjennings Thanks again for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emitting an event with a value of 0 produces a GameEvent instead
2 participants
@mattjennings @eonarheim