Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#2435] Graphics are consistently drawn around the contentArea regardless of resolution #2439

Merged
merged 5 commits into from
Aug 6, 2022

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Jul 30, 2022

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #2435

Changes:

  • With the *AndFill style display modes, basing the camera postion on the Screen.contentArea will keep things drawing consistently
  • Sets the origin for CoordPlan.Screen space graphics to the top left of the Screen.contentArea
  • Added visual test

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Jul 30, 2022
@eonarheim eonarheim changed the title fix: [#2435] Graphics are consitently drawn around the contentArea gardless of resolution fix: [#2435] Graphics are consitently drawn around the contentArea regardless of resolution Aug 3, 2022
@eonarheim eonarheim changed the title fix: [#2435] Graphics are consitently drawn around the contentArea regardless of resolution fix: [#2435] Graphics are consistently drawn around the contentArea regardless of resolution Aug 3, 2022
@eonarheim eonarheim merged commit 5ab23b2 into main Aug 6, 2022
@eonarheim eonarheim deleted the fix/2435-contentarea-resize branch August 6, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screen.contentArea and canvas seems to get out of sync when resizing window
1 participant