Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#2440] Multiply current gfx ctx opacity #2449

Merged
merged 4 commits into from
Aug 5, 2022
Merged

fix: [#2440] Multiply current gfx ctx opacity #2449

merged 4 commits into from
Aug 5, 2022

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Aug 3, 2022 •
edited
Loading

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #2440

Changes:

  • Multiplies the current context opacity in the GraphicsSystem to respect opacity set on the context outside of the GraphicsComponent

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Aug 3, 2022
@eonarheim eonarheim merged commit fa65eb8 into main Aug 5, 2022
@eonarheim eonarheim deleted the fix/2440-scene-predraw branch August 5, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Context Opacity Not Working as Intended
1 participant
@eonarheim