New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#2450] Sound looping regression #2451

Merged

eonarheim merged 2 commits into main from fix/2450-sound-looping

Aug 5, 2022

Member

eonarheim commented Aug 4, 2022 •

edited

Loading

===:clipboard: PR Checklist :clipboard:===

📌 issue exists in github for these changes
🔬 existing tests still pass
🙈 code conforms to the style guide
📐 new tests written and passing / old tests updated with new scenario(s)
📄 changelog entry added (or not needed)

==================

Closes #2450

Changes:

Avoids setting a duration on the underlying web audio instance, this causes odd behavior in looping and playing


          fix: [#2450] Sound looping regression

e0e7666

github-actions bot added the bug label


          add tests

fc8fe92

eonarheim merged commit 5c96867 into main

eonarheim deleted the fix/2450-sound-looping branch

August 5, 2022 21:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug