Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [#2468] add clone() method to ex.SpriteSheet #2469

Merged
merged 3 commits into from
Aug 26, 2022

Conversation

mattjennings
Copy link
Contributor

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #2468

Changes:

  • Added clone() method to ex.SpriteSheet

@mattjennings mattjennings marked this pull request as ready for review August 25, 2022 23:12
Copy link
Member

@eonarheim eonarheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattjennings Looks excellent!

I ran the CI locally and everything is solid.

Not sure why GH isn't running the approve/workflow I'm going to reach out the GH support to investigate.

@eonarheim eonarheim merged commit b1f21e5 into excaliburjs:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SpriteSheet.clone()
2 participants