Fix x-axis bug in actions.scaleTo
#2471
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if scaling only on the x-axis, the action would never complete.
===:clipboard: PR Checklist :clipboard:===
==================
Closes #2470
Changes:
Fixes a bug I found in the
ScaleTo
action, where scaling on the x-axis exclusively may never complete. TheisComplete
method accidentally testedtx.scale.y
against the x-axis, rather than testingtx.scale.x
against the x-axis. I wrote the test first, watched it fail, and then fixed the bug and watched the test pass.It looks like since I'm a first-time contributor I'll need approval from a maintainer to actually run the CI checks, but I pinky swear I ran
npm run all
locally and it all passed. 😄