Support wrapping ex.Text graphics #2472

RyanGrieb · 2022-08-27T20:37:56Z

===:clipboard: PR Checklist :clipboard:===

📌 issue exists in github for these changes
🔬 existing tests still pass
🙈 code conforms to the style guide
📐 new tests written and passing / old tests updated with new scenario(s)
📄 changelog entry added (or not needed)

==================

Changes:

Add maxWidth TextOption to support word wrapping

Hi, I think I've progressed enough to post a draft PR.
Currently wrapping works when the maxWidth option is provided for the ex.Text class.

There is a bug currently where text > 2 lines isn't rendered since I don't update the ex.Text height properly when we word wrap.
If there is any other outstanding problems in the code/PR please let me know!

eonarheim · 2022-08-31T01:55:46Z

@RyanGrieb thanks for the PR! I'll have some time to look this over this week sometime👍

Closes excaliburjs#2473 This PR fixes an issue where a degenerate 0 sized collision causes issues with the precollision event emit. Previously an erroneous left precollision would be emitted when the minimum translation vector (mtv) was `(-0, -0)` <img width="299" alt="image" src="https://user-images.githubusercontent.com/612071/187574499-96889716-ba1a-418e-995e-b7673ce643e2.png"> ## Changes: - Filters out 0 sized contacts in precollision to guard against a degenerate side calculation

eonarheim · 2022-09-09T23:02:08Z

@RyanGrieb the code looks good to my eyes! Exactly what I would have expected

There is one failing test, I'm trying to figure out why the text generated is slightly shifted up and to the left. It might be the case that the new changes are more correct, I'm just not sure why it's different quite yet.

eonarheim · 2022-09-09T23:21:42Z

@RyanGrieb Actually! I believe the PR code is more correct the resetTransform() prevents the context transform from being corrupted with previous calls to _applyFont() which is a problem in the current main branch. Many thanks!

I think this PR is ready, update the failing test, add a new test for the maxWidth, and fix the height issue you spoke about 👍

RyanGrieb · 2022-09-10T00:55:49Z

@eonarheim I believe corrected the height issue. I'm not sure how you'd like me to correct the failing test. Should I replace the image? Also, how would I individually run the test 722 and visually look at it.

Looking good 😄
Once I fix the failing test I'll complete the rest of the PR checklist & merge the separate commit messages.

RyanGrieb · 2022-09-10T00:59:13Z

Also I haven't tested this w/ ex.SpriteFont. I don't think we should merge until I look at it & test it properly.

eonarheim · 2022-09-10T13:45:48Z

I'm not sure how you'd like me to correct the failing test. Should I replace the image? Also, how would I individually run the test 722 and visually look at it.

@RyanGrieb good questions!

Yes please do replace the expected test images if you can (you can copy paste the base64 image into a browser and download it to the appropriate spec in src/spec/images folder). You can grab the expected linux image from the failing test in the github action, but if you don't have a windows machine I can add a commit to your fork with expected windows image 👍

You can add an f to the front of the test it to "focus" the test and only run that one fit('can reuse a font', async () => {.

Really appreciate the work on this feature! It'll be a huge value add to Excalibur!

RyanGrieb · 2022-09-10T18:41:47Z

Word wrap for sprite font added, add changelog entry

Weird spacing on the left side though, not sure if it's supposed to be like this.

eonarheim · 2022-09-11T21:04:49Z

@RyanGrieb This is looking great! Let me know when you're ready for review

Weird spacing on the left side though, not sure if it's supposed to be like this.

@RyanGrieb I think that's expected with the SpriteFont by default in the current implementation. The SpriteFont image has some extra padding in the individual sprites per glyph. Although there may be a case for adjusting the first letter offset in addition to specifying the spacing, but I think that would be best in a separate issue/PR 👍

…2410) Closes excaliburjs#2401 This PR implements an arbitrary raycasting api in Excalibur ```typescript const hits = engine.currentScene.physics.rayCast(new ex.Ray(player.pos, ex.Vector.Down), { maxDistance: 100, collisionGroup: blockGroup, searchAllColliders: false }); ``` <img width="797" alt="image" src="https://user-images.githubusercontent.com/612071/178625499-d9f97052-5b18-49fe-9440-89bd93e46ff6.png"> ## Changes: - Fix issue where TileMaps weren't correctly added to the collider data structure - Add physics world with raycasting endpoint

github-actions · 2022-11-11T00:09:19Z

This PR hasn't had any recent activity lately and is being marked as stale automatically.

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…2534) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…js#2533) Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. - [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases) - [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2) --- updated-dependencies: - dependency-name: decode-uri-component dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.1.0 to 1.4.2. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md) - [Commits](webpack/loader-utils@v1.1.0...v1.4.2) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

eonarheim · 2022-12-03T02:56:19Z

Hi @RyanGrieb sorry about the delay on this PR! Life happened to me!

Is it okay if I push a few commits to your fork? This is definitely something that would be nice to include in the next release of excalibur!

…to RyanGrieb-line-wrap2

RyanGrieb · 2022-12-03T03:40:13Z

@eonarheim Go for it. I couldn’t get tests working for some reason on my machine.

eonarheim · 2023-01-14T02:01:43Z

@RyanGrieb Thanks for working on this feature! Sorry about the long delay on the merge!

We appreciate the hard work this is great feature!

Support wrapping ex.Text graphics

b7a22c3

renovate bot and others added 12 commits September 1, 2022 04:57

chore: Update dependency @babel/core to v7.18.13

7a1d05f

chore: Update dependency terser-webpack-plugin to v5.3.6

32bec02

chore: Update dependency eslint-plugin-jsdoc to v39.3.6

056b66a

chore: Update storybook monorepo to v6.5.10

7290039

chore: Update Node.js to v16.17.0

83dd816

chore: Update dependency @types/jasmine to v4.3.0

4d3c6e2

chore: Update dependency @types/webpack-env to v1.18.0

888765c

chore: Update dependency core-js to v3.25.0

893eb62

chore: Update dependency eslint to v8.23.0

503d2e2

chore: Update dependency webpack to v5.74.0

5921923

chore: Update jasmine monorepo to v4.3.0

fc63c81

Make FontTextInstance use ex.Text maxWidth when calculating total lines

080f025

RyanGrieb added 2 commits September 10, 2022 13:14

Support word wrapping with SpriteFont

10226af

Add wordwrap to changelog

541fbd0

eonarheim and others added 6 commits September 11, 2022 18:30

chore: Update Node.js to v16.17.1

821ad2e

chore: Update dependency karma to v6.4.1

4e1b523

chore: Update storybook monorepo to v6.5.12

53d4a49

chore: Update dependency core-js to v3.25.3

cf5c695

chore: Update dependency @babel/core to v7.19.3

47bd4f8

renovate bot added 4 commits November 4, 2022 02:52

chore: Update storybook monorepo to v6.5.13

2521861

chore: Update dependency typescript to v4.8.4

ab9535d

chore: Update dependency minimatch to 3.0.5 [SECURITY]

9c3608e

chore: Update dependency core-js to v3.26.0

a947c6a

github-actions bot added the stale This issue or PR has not had any activity recently label Nov 11, 2022

renovate bot and others added 15 commits December 1, 2022 08:49

chore: Update dependency css-loader to v6.7.2

7b3d16c

chore: Update Node.js to v16.18.1

1018b84

chore: Update dependency core-js to v3.26.1

e76c3db

chore: Update dependency serve to v14.1.2

b436e7c

chore: Update dependency ts-loader to v9.4.2

6124e84

chore: Update dependency @babel/core to v7.20.5

beee7af

chore: Update dependency babel-loader to v8.3.0

36e2c7e

chore: Update dependency eslint to v8.29.0

e4018c7

chore: Update actions/checkout action to v3 (excaliburjs#2502)

e7da42c

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore: Update actions/setup-node action to v3 (excaliburjs#2503)

4d72840

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore: Update dependency eslint-plugin-jsdoc to v39.6.4 (excaliburjs#…

3194fb8

…2534) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore: Update dependency copy-webpack-plugin to v11 (excaliburjs#2507)

5392309

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore: Update dependency @octokit/rest to v19 (excaliburjs#2506)

e96e9af

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Merge branch 'line-wrap' of https://github.com/RyanGrieb/Excalibur in…

53d47b5

…to RyanGrieb-line-wrap2

eonarheim removed the stale This issue or PR has not had any activity recently label Dec 3, 2022

fix tests locally

e9c8c3e

eonarheim marked this pull request as ready for review December 3, 2022 03:54

Add a couple tests for word wrap

f27c0bf

eonarheim merged commit 51ea101 into excaliburjs:main Jan 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support wrapping ex.Text graphics #2472

Support wrapping ex.Text graphics #2472

RyanGrieb commented Aug 27, 2022 •

edited by eonarheim

Loading

eonarheim commented Aug 31, 2022

eonarheim commented Sep 9, 2022

eonarheim commented Sep 9, 2022

RyanGrieb commented Sep 10, 2022

RyanGrieb commented Sep 10, 2022

eonarheim commented Sep 10, 2022

RyanGrieb commented Sep 10, 2022

eonarheim commented Sep 11, 2022

github-actions bot commented Nov 11, 2022

eonarheim commented Dec 3, 2022

RyanGrieb commented Dec 3, 2022

eonarheim commented Jan 14, 2023

Support wrapping ex.Text graphics #2472

Support wrapping ex.Text graphics #2472

Conversation

RyanGrieb commented Aug 27, 2022 • edited by eonarheim Loading

Changes:

eonarheim commented Aug 31, 2022

eonarheim commented Sep 9, 2022

eonarheim commented Sep 9, 2022

RyanGrieb commented Sep 10, 2022

RyanGrieb commented Sep 10, 2022

eonarheim commented Sep 10, 2022

RyanGrieb commented Sep 10, 2022

eonarheim commented Sep 11, 2022

github-actions bot commented Nov 11, 2022

eonarheim commented Dec 3, 2022

RyanGrieb commented Dec 3, 2022

eonarheim commented Jan 14, 2023

RyanGrieb commented Aug 27, 2022 •

edited by eonarheim

Loading