New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#2597] Add defense to ScreenElement ctor for zero width/height #2602

Merged

eonarheim merged 1 commit into main from bugfix/2597-zero-width-height-screen-element

Mar 11, 2023

Member

eonarheim commented Mar 11, 2023

===:clipboard: PR Checklist :clipboard:===

📌 issue exists in github for these changes
🔬 existing tests still pass
🙈 code conforms to the style guide
📐 new tests written and passing / old tests updated with new scenario(s)
📄 changelog entry added (or not needed)

==================

Closes #2597

Changes:

Adds defense to the ScreenElement to avoid an unnecessary warning


          fix: [#2597] Add defense to ScreenElement ctor for zero width/height

b103159

eonarheim merged commit 1ab5b57 into main

eonarheim deleted the bugfix/2597-zero-width-height-screen-element branch

March 11, 2023 04:33

eonarheim mentioned this pull request

ScreenElements do not tolerate 0 width and 0 height sizes #2601

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet