Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#1512] Grab window focus by default for x-origin iframes #2660

Merged
merged 6 commits into from
Jun 14, 2023

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Jun 14, 2023

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

This PR adds a new engine option (which is on by default) to grab the window focus when hosted in an iframe. This allows keyboard events to work by default.

Confirmed on itch.io https://eonarheim.itch.io/iframe-test

Closes #1512

@eonarheim eonarheim merged commit 799ff70 into main Jun 14, 2023
@eonarheim eonarheim deleted the bugfix/1512-keyboard-iframe branch June 14, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Add KeyboardScope option
1 participant