Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #2848 Sprite tint respected in constructor #2852

Merged
merged 5 commits into from
Dec 21, 2023
Merged

fix: #2848 Sprite tint respected in constructor #2852

merged 5 commits into from
Dec 21, 2023

Conversation

eonarheim
Copy link
Member

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #2848

Changes:

  • Fixes sprite tint constructor value passing
  • Fixes sprite tint on cloned sprites
  • Fixes width/height inconsistency discovered in new tests
  • New tests

@eonarheim eonarheim merged commit 410647a into main Dec 21, 2023
4 of 5 checks passed
@eonarheim eonarheim deleted the bugfix/sprite-tint-2848 branch December 21, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sprite tint doesn't seem to have any effect.
1 participant
@eonarheim