Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue with pointer events on screen elements #2902

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Jan 26, 2024

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

This PR fixes an issue discovered on the discord around pointer events and ScreenElements

  • Fixed issue where pointer events did not work properly when using [[ScreenElement]]s
  • Fixed issue where debug draw was not accurate when using *AndFill suffixed [[DisplayMode]]s

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Jan 26, 2024
@eonarheim eonarheim merged commit 2bdc373 into main Jan 26, 2024
4 of 5 checks passed
@eonarheim eonarheim deleted the fix/pointers-on-screen-elements branch January 26, 2024 21:36
eonarheim added a commit that referenced this pull request Jan 26, 2024
This PR fixes an issue discovered on the discord around pointer events and ScreenElements

- Fixed issue where pointer events did not work properly when using [[ScreenElement]]s
- Fixed issue where debug draw was not accurate when using *AndFill suffixed [[DisplayMode]]s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant