Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Screen to world coord conversion when using fit container #2961

Merged

Conversation

eonarheim
Copy link
Member

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Fix issue caused by recent change to FitContainer where percent units were not accounted for when transforming coordinates

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Mar 10, 2024
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 445b741
Status: ✅  Deploy successful!
Preview URL: https://335334fa.excaliburjs.pages.dev
Branch Preview URL: https://fix-fit-content-viewport-scr.excaliburjs.pages.dev

View logs

@eonarheim eonarheim merged commit 0233d98 into main Mar 10, 2024
6 of 7 checks passed
@eonarheim eonarheim deleted the fix/fit-content-viewport-screen-coordinate-conversion branch March 10, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant