Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement image wrapping configuration #2963

Merged
merged 7 commits into from
Apr 7, 2024

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Mar 12, 2024

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

This PR allows users to configure the ImageSource wrapping mode: Clamp, Repeat, or Mirror.

Example of using the Repeat mode to repeat noise textures over time

fire-shader.mp4

@github-actions github-actions bot added the enhancement Label applied to enhancements or improvements to existing features label Mar 12, 2024
Copy link

cloudflare-workers-and-pages bot commented Mar 12, 2024

Deploying excaliburjs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 482e530
Status: ✅  Deploy successful!
Preview URL: https://f10ec2f4.excaliburjs.pages.dev
Branch Preview URL: https://feat-add-imagesource-wrappin.excaliburjs.pages.dev

View logs

@eonarheim eonarheim merged commit 470439f into main Apr 7, 2024
8 checks passed
@eonarheim eonarheim deleted the feat/add-imagesource-wrapping-configuration branch April 7, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Label applied to enhancements or improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant