Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==================
This PR resolves a circular dependency issue in Excalibur.js when using TypeScript source files directly. It refactors
ParticleEmitter
by isolating it into a separate file and adjusting the dependency management inParticles.ts
.This PR has the advantage that you should not encounter this problem if Webpack should ever be replaced.
Closes #3055
Changes
ParticleEmitter
: MovedParticleEmitter
to its own file to manage dependencies more effectively.Particles.ts
: Replaced direct dependency with a type import ofParticleEmitter
.instanceof
check with aconstructor
presence check.