Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#3060] SpriteFont measureText with scale #3062

Merged
merged 4 commits into from
May 15, 2024
Merged

fix: [#3060] SpriteFont measureText with scale #3062

merged 4 commits into from
May 15, 2024

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented May 14, 2024 •
edited
Loading

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #3060

Changes:

  • Adds sandbox test with repro
  • Updates spritefont to include scale

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label May 14, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented May 14, 2024 •
edited
Loading

Deploying excaliburjs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 239bfa1
Status: ✅  Deploy successful!
Preview URL: https://82657212.excaliburjs.pages.dev
Branch Preview URL: https://fix-3060-spritefont-measure.excaliburjs.pages.dev

View logs

@eonarheim eonarheim merged commit 5dcff5d into main May 15, 2024
7 of 8 checks passed
@eonarheim eonarheim deleted the fix/3060-spritefont-measure-with-scale branch May 15, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SpriteFont.measureText is not using scale property
1 participant
@eonarheim