On addon remove #3143
Merged
On addon remove #3143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying excaliburjs with
|
| Latest commit: |
a1e216b
|
| Status: | ⚡️ Build in progress... |
|
@jyoung4242 Thanks again for adding this feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add onAdd() and onRemove() methods to entities.
also tested to work with the 'add' and 'remove' event listeners as well
Okay, some issues with this...
I stopped working on it when i realized the documentation impact and my lack of competency regarding adding tests to my code submissions
What's changed:
entity.ts has onAdd and onRemove methods added
entity.ts and actor.ts has modified update loops to manage these events
updated events.ts to include add and remove
updated lifecycleevents.ts to include has_add and has_remove
and the canRemove and canAdd interfaces
and i added some bunk testing to ActorSpec.ts, i want to apologize in advance for it....
:|
I've performed manual testing of this code