Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#3098] Make collision events consistent targets #3238

Merged
merged 8 commits into from
Oct 23, 2024

Conversation

eonarheim
Copy link
Member

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #3098

Changes:

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Oct 6, 2024
Copy link

cloudflare-workers-and-pages bot commented Oct 6, 2024

Deploying excaliburjs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1b02d83
Status: ✅  Deploy successful!
Preview URL: https://431b1dba.excaliburjs.pages.dev
Branch Preview URL: https://fix-3098-collision-event-con.excaliburjs.pages.dev

View logs

@eonarheim eonarheim merged commit 591ff8e into main Oct 23, 2024
8 checks passed
@eonarheim eonarheim deleted the fix/3098-collision-event-consistent branch October 23, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

precollision event inconsistencies between Actor hook and ColliderComponent event
1 participant