-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Nine-slice #3241
feat: Nine-slice #3241
Conversation
Deploying excaliburjs with Cloudflare Pages
|
src/spec/nineSliceSpec.ts
Outdated
expect(ex.NineSlice).toBeDefined(); | ||
}); | ||
|
||
it('generates a new id', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already tested in base class, no need to test it again, since there's no change in functionality in the class here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
src/spec/nineSliceSpec.ts
Outdated
|
||
it('can exist', () => { | ||
// eslint-disable-next-line no-console | ||
console.log('ex.NineSlice being ran'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, that's debugging, will fix
This doesn't have an issue number and doesn't close any issue numbers.
Scope: This is a new Graphic object
Files Impacted:
Created: \Excalibur\src\engine\Graphics\NineSlice.ts
Created: \Excalibur\src\spec\NineSliceSpec.ts
Created: \Excalibur\site\docs\04-graphics\04.6-nineslice.mdx
all existing tests passed locally