Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Nine-slice #3241

Merged
merged 21 commits into from
Oct 30, 2024
Merged

feat: Nine-slice #3241

merged 21 commits into from
Oct 30, 2024

Conversation

jyoung4242
Copy link
Contributor

@jyoung4242 jyoung4242 commented Oct 11, 2024

This doesn't have an issue number and doesn't close any issue numbers.

Scope: This is a new Graphic object

Files Impacted:

Created: \Excalibur\src\engine\Graphics\NineSlice.ts
Created: \Excalibur\src\spec\NineSliceSpec.ts
Created: \Excalibur\site\docs\04-graphics\04.6-nineslice.mdx

all existing tests passed locally

Copy link

cloudflare-workers-and-pages bot commented Oct 11, 2024

Deploying excaliburjs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1073071
Status: ✅  Deploy successful!
Preview URL: https://14a83587.excaliburjs.pages.dev
Branch Preview URL: https://nineslice.excaliburjs.pages.dev

View logs

expect(ex.NineSlice).toBeDefined();
});

it('generates a new id', () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already tested in base class, no need to test it again, since there's no change in functionality in the class here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch


it('can exist', () => {
// eslint-disable-next-line no-console
console.log('ex.NineSlice being ran');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, that's debugging, will fix

src/spec/nineSliceSpec.ts Outdated Show resolved Hide resolved
src/engine/Graphics/NineSlice.ts Outdated Show resolved Hide resolved
src/engine/Graphics/NineSlice.ts Outdated Show resolved Hide resolved
src/engine/Graphics/NineSlice.ts Outdated Show resolved Hide resolved
src/engine/Graphics/NineSlice.ts Outdated Show resolved Hide resolved
@eonarheim eonarheim merged commit c980349 into main Oct 30, 2024
6 of 7 checks passed
@eonarheim eonarheim deleted the nineslice branch October 30, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants