Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [#150] Implement SVG support in ImageSource with static builder #3244

Merged
merged 6 commits into from
Oct 15, 2024
Merged

feat: [#150] Implement SVG support in ImageSource with static builder #3244

merged 6 commits into from
Oct 15, 2024

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Oct 14, 2024 •
edited
Loading

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #150

Changes:

  • Implement svg source string support
  • Allow optional sprite arguments .toSprite(options:? SpriteOptions)

@github-actions github-actions bot added the enhancement Label applied to enhancements or improvements to existing features label Oct 14, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 14, 2024 •
edited
Loading

Deploying excaliburjs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 66334a2
Status: ✅  Deploy successful!
Preview URL: https://6d604a84.excaliburjs.pages.dev
Branch Preview URL: https://feat-svg-images.excaliburjs.pages.dev

View logs

@eonarheim eonarheim merged commit 0624e76 into main Oct 15, 2024
8 checks passed
@eonarheim eonarheim deleted the feat/svg-images branch October 15, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Label applied to enhancements or improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for SVG images as a resource type
1 participant
@eonarheim