Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Slide Transition #3248

Merged
merged 19 commits into from
Oct 23, 2024
Merged

feat: Add Slide Transition #3248

merged 19 commits into from
Oct 23, 2024

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Oct 20, 2024

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

slide.mp4

Changes:

  • Added a method to force graphics on screen ex.GraphicsComponent.forceOnScreen
  • Added new ex.Slide scene transition, which can slide a screen shot of the current screen: up, down, left, or right. Optionally you can add an ex.EasingFunction, by default ex.EasingFunctions.Linear
    game.goToScene('otherScene', {
      destinationIn: new ex.Slide({
        duration: 1000,
        easingFunction: ex.EasingFunctions.EaseInOutCubic,
        slideDirection: 'up'
      })
    });
  • Fixed issue where ex.Engine.screenshot() images may not yet be loaded in time for use in ex.Transitions
  • Fixed issue where there would be an incorrect background color for 1 frame when transitioning to a new scene

@github-actions github-actions bot added the enhancement Label applied to enhancements or improvements to existing features label Oct 20, 2024
Copy link

cloudflare-workers-and-pages bot commented Oct 21, 2024

Deploying excaliburjs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 89aa10f
Status: ✅  Deploy successful!
Preview URL: https://b92811bf.excaliburjs.pages.dev
Branch Preview URL: https://feat-transition-slide.excaliburjs.pages.dev

View logs

@eonarheim eonarheim merged commit 6ff8778 into main Oct 23, 2024
6 of 7 checks passed
@eonarheim eonarheim deleted the feat/transition-slide branch October 23, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Label applied to enhancements or improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant