-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Closes #515] Refactor sound resources to address inconsistent behaviors #644
Merged
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
46133f7
Add proper simultaneous sound handling to AudioTag and WebAudio provi…
kamranayub e8e130c
Refactor sounds to be simpler
kamranayub d2b0b9c
Fix other audio test to not do simultaneous plays
kamranayub 8a676f8
Compile dists and address TSLint
kamranayub 20d21e6
Merge latest PRs and recompile dists
kamranayub 364e30c
Simplify and consolidate Sound resource and sound implementations
kamranayub ffa05d1
Fix web audio offset calculation to be in seconds
kamranayub 9bab3e5
Fix sandbox
kamranayub b78a3f5
Compile dists
kamranayub 55efb9c
Fix some potential issues
kamranayub 43ef13d
Add initial sound tests
kamranayub d4dca5e
Add sound unit test coverage
kamranayub 1f31c28
Add callback tests
kamranayub c7df9a8
Add callback test with data preloaded
kamranayub c447e7f
Fix TSlint and add `instanceCount()` method to get number of currentl…
kamranayub 0f11c8d
Compile dists
kamranayub b48d89f
Ignore audio implementations for coverage
kamranayub 216c4c1
Compile dists
kamranayub b2c74a1
Merge in master changes and recompile dists
kamranayub 6bc6e2f
Add more debug messages for debugging
kamranayub 10a8a7e
Fix tslint task to include all engine files
kamranayub 4827768
Fix tslint errors
kamranayub 88d509a
Recompile dists
kamranayub File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
/// <reference path="../Promises.ts" /> | ||
|
||
module ex { | ||
export interface IAudio { | ||
setVolume(volume: number); | ||
setLoop(loop: boolean); | ||
isPlaying(): boolean; | ||
play(): ex.Promise<any>; | ||
pause(); | ||
stop(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
module ex { | ||
|
||
/** | ||
* Represents an audio implementation like [[AudioTag]] or [[WebAudio]] | ||
*/ | ||
export interface IAudioImplementation { | ||
|
||
/** | ||
* XHR response type | ||
*/ | ||
responseType: string; | ||
|
||
/** | ||
* Processes raw data and transforms into sound data | ||
*/ | ||
processData(data: Blob|ArrayBuffer): ex.Promise<string|AudioBuffer>; | ||
|
||
/** | ||
* Factory method that returns an instance of a played audio track | ||
*/ | ||
createInstance(data: string|AudioBuffer): IAudio; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add docs