Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add finite execution count limit to timers #974

Merged
merged 2 commits into from
Apr 21, 2018
Merged

Add finite execution count limit to timers #974

merged 2 commits into from
Apr 21, 2018

Conversation

alanag13
Copy link
Member

Closes #905.

Changes:

  • Allow timers to repeat execution a finite number of times via new ex.Timer(fn, interval, numTimes);
  • Allow times to be reset with a different limit via timer.reset(interval, numTimes)
  • Allow access to the number of times a timer has been executed via timer.timesRepeated

Copy link
Member

@eonarheim eonarheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@eonarheim eonarheim merged commit 578c78e into master Apr 21, 2018
@eonarheim eonarheim deleted the finite-time branch April 21, 2018 13:58
@eonarheim eonarheim added this to the 0.17.0 Release milestone Apr 23, 2018
LoserAntbear pushed a commit to LoserAntbear/Excalibur that referenced this pull request May 8, 2018
…urjs#974)

Closes excaliburjs#905.

- Allow timers to repeat execution a finite number of times via `new ex.Timer(fn, interval, numTimes);`
- Allow times to be reset with a different limit via `timer.reset(interval, numTimes)`
- Allow access to the number of times a timer has been executed via timer.timesRepeated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants