New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure non-* CORS origin header is set if no req headers sent #149

Merged

dwelle merged 3 commits into master from fix_cors

Jan 14, 2021

Member

dwelle commented Jan 14, 2021

fix excalidraw/excalidraw#2775

* is not allowed as Access-Control-Allow-Origin header when credentials is set. Setting credentials is outside of our control (CORS Errors after updating to 2.2.0 socketio/socket.io#3381), so we need to fix it here.

dwelle added 3 commits

January 14, 2021 12:10


          fix: ensure non-* CORS origin header is set if no req headers sent

c970c74


          fallback to excalidraw.com if no origin header present

1de26f6


          fix lint

1cc5543

lipis approved these changes

View reviewed changes

dwelle merged commit dda25d7 into master

dwelle deleted the fix_cors branch

January 14, 2021 13:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet