Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build script in installation docs #5

Merged
merged 3 commits into from
Oct 18, 2021

Conversation

gathuku
Copy link
Contributor

@gathuku gathuku commented Oct 16, 2021

@excid3 I have been missing this a lot. Hope it will help someone if it's documented.

@gathuku gathuku force-pushed the package-build-script branch from 49f1771 to fa63fb1 Compare October 16, 2021 11:59
@gathuku gathuku force-pushed the package-build-script branch from fa63fb1 to d0f0ab1 Compare October 16, 2021 12:00
Copy link
Owner

@excid3 excid3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You read my mind. I was just thinking about how that was missing yesterday!

Can we change this to use npm set-script "node esbuild.config.js" to match what rails does in the JSbundling gem?

@gathuku
Copy link
Contributor Author

gathuku commented Oct 16, 2021

Sure @excid3 , Looks like the feature is only in npm 7

@gathuku gathuku requested a review from excid3 October 16, 2021 13:26
@excid3
Copy link
Owner

excid3 commented Oct 18, 2021

Yeah, it is only in npm 7 which is fine because that's what the js/cssbundling libraries require too.

@excid3 excid3 merged commit b3745a1 into excid3:main Oct 18, 2021
@gathuku gathuku deleted the package-build-script branch October 18, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants