Fix/nopreview #55
Fix/nopreview #55
Conversation
…d app detail page
|
this fixes issue #51 point 3 |
| @@ -4,6 +4,8 @@ | |||
| ) | |||
| from crew.models import Crew | |||
|
|
|||
| no_preview_150 = '/statics/images/no-preview-150.png' | |||
| no_preview = '/statics/images/no-preview.png' | |||
There was a problem hiding this comment.
Can try {% static \"images/no-preview.png\" %} here for me? I think this is the better way, if possible
There was a problem hiding this comment.
👍 as long as we don't hard code the URL.
For Static reverse outside of templates, we can still make use the templatetags at staticfiles.
django.contrib.staticfiles.templatetags.staticfiles.static
from django.contrib.staticfiles.templatetags.staticfiles import static
no_preview = static('images/no-preview.png')
Some UI fixes.
…02-store into fix/nopreview Conflicts: multimedia/views.py
|
rebased this branch to master and update the image reference to static |
|
somehow after I rebased, changes that I did not make appear in the "files changed" tab. Don't know why, but this is ready for merge. |
|
Shouldn't have rebased in this case. I guess @9gix is right, just merge unless you are sure what you are doing. I am not sure what will happen if we merge this, bcuz usually if this happened to me during 2103, I will fix the branch so that changes from the master does not appear in the PR. |
resized no_preview.png, added no_review sized 150x150 px, modify views and base_list.html accordingly