Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install step does not include linkify dependency #791

Closed
jhcole opened this issue Jul 20, 2023 · 0 comments · Fixed by #792
Closed

Install step does not include linkify dependency #791

jhcole opened this issue Jul 20, 2023 · 0 comments · Fixed by #792
Labels
documentation Improvements or additions to documentation

Comments

@jhcole
Copy link
Contributor

jhcole commented Jul 20, 2023

Describe the gap in the current documentation

Following the current contribution guidelines, some tests fail when running pytest if linkify is not installed.

========================================================== short test summary info ===========================================================
FAILED tests/test_renderers/test_myst_config.py::test_cmdline[40-linkify] - SystemExit: 1
FAILED tests/test_renderers/test_myst_config.py::test_cmdline[50-gfm-strikethrough] - SystemExit: 1
FAILED tests/test_renderers/test_myst_config.py::test_cmdline[68-gfm-disallowed-html] - SystemExit: 1
FAILED tests/test_renderers/test_myst_config.py::test_cmdline[95-gfm-autolink] - SystemExit: 1
FAILED tests/test_sphinx/test_sphinx_builds.py::test_extended_syntaxes - ModuleNotFoundError: Linkify enabled but not installed.
======================================== 5 failed, 1057 passed, 12 skipped, 29923 warnings in 16.45s =========================================

Describe the solution you'd like

Add linkify as an optional dependency in the pip install step.

@jhcole jhcole added the documentation Improvements or additions to documentation label Jul 20, 2023
jhcole added a commit to jhcole/MyST-Parser that referenced this issue Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant