Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 mypy- disallow 'any generics' #865

Merged

Conversation

danieleades
Copy link
Contributor

  • make mypy config stricter by disallowing 'any' generics
  • fix some errors by adding generics
  • 'whitelist' the modules with excessive errors
  • includes some changes due to autoformatting pyproject.toml

this whitelist should be shrunk and eventually removed over time. It should never get larger.

@chrisjsewell chrisjsewell changed the title mypy- disallow 'any generics' 🔧 mypy- disallow 'any generics' Mar 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (4e7128c) to head (7b75bb3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #865   +/-   ##
=======================================
  Coverage   90.06%   90.06%           
=======================================
  Files          24       24           
  Lines        3373     3373           
=======================================
  Hits         3038     3038           
  Misses        335      335           
Flag Coverage Δ
pytests 90.06% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers!

@chrisjsewell chrisjsewell merged commit e238b6b into executablebooks:master Mar 26, 2024
20 checks passed
@danieleades danieleades deleted the mypy-disallow-any-generics branch March 26, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants