Set no_implicit_optional=True mypy conf

.mypy.ini

@@ -1,3 +1,4 @@
 [mypy]
 warn_unused_ignores = True
 warn_redundant_casts = True
+no_implicit_optional = True

markdown_it/common/normalize_url.py

@@ -1,6 +1,6 @@
 import html
 import re
-from typing import Callable
+from typing import Callable, Optional
 from urllib.parse import urlparse, urlunparse, quote, unquote  # noqa: F401
 
 from .utils import ESCAPABLE
@@ -166,7 +166,7 @@ def normalizeLinkText(link):
 GOOD_DATA_RE = re.compile(r"^data:image\/(gif|png|jpeg|webp);")
 
 
-def validateLink(url: str, validator: Callable = None):
+def validateLink(url: str, validator: Optional[Callable] = None):
     """Validate URL link is allowed in output.
 
     This validator can prohibit more than really needed to prevent XSS.

markdown_it/extensions/container/index.py

@@ -1,6 +1,6 @@
 """Process block-level custom containers."""
 from math import floor
-from typing import Callable
+from typing import Callable, Optional
 
 from markdown_it import MarkdownIt
 from markdown_it.common.utils import charCodeAt
@@ -11,7 +11,7 @@ def container_plugin(
     md: MarkdownIt,
     name: str,
     marker: str = ":",
-    validate: Callable[[str, str], bool] = None,
+    validate: Optional[Callable[[str, str], bool]] = None,
     render=None,
 ):
     """Plugin ported from

markdown_it/parser_block.py

@@ -1,6 +1,6 @@
 """Block-level tokenizer."""
 import logging
-from typing import List
+from typing import List, Optional
 
 from .ruler import Ruler
 from .token import Token
@@ -92,7 +92,14 @@ def tokenize(
                 line += 1
                 state.line = line
 
-    def parse(self, src: str, md, env, outTokens: List[Token], ords: List[int] = None):
+    def parse(
+        self,
+        src: str,
+        md,
+        env,
+        outTokens: List[Token],
+        ords: Optional[List[int]] = None,
+    ):
         """Process input string and push block tokens into `outTokens`."""
         if not src:
             return

markdown_it/rules_block/state_block.py

@@ -1,4 +1,4 @@
-from typing import List
+from typing import List, Optional
 
 from ..token import Token
 from ..ruler import StateBase
@@ -7,7 +7,12 @@
 
 class StateBlock(StateBase):
     def __init__(
-        self, src: str, md, env, tokens: List[Token], srcCharCode: List[int] = None
+        self,
+        src: str,
+        md,
+        env,
+        tokens: List[Token],
+        srcCharCode: Optional[List[int]] = None,
     ):
 
         self.src = src

markdown_it/rules_core/smartquotes.py

@@ -1,7 +1,7 @@
 """Convert straight quotation marks to typographic ones
 """
 import re
-from typing import List
+from typing import Any, Dict, List
 
 from .state_core import StateCore
 from ..common.utils import charCodeAt
@@ -22,7 +22,7 @@ def replaceAt(string: str, index: int, ch: str):
 
 
 def process_inlines(tokens: List[Token], state: StateCore):
-    stack = []
+    stack: List[Dict[str, Any]] = []
 
     for i in range(len(tokens)):
         token = tokens[i]
@@ -202,5 +202,5 @@ def smartquotes(state: StateCore):
 
         if token.type != "inline" or not QUOTE_RE.search(token.content):
             continue
-
+        assert token.children is not None
         process_inlines(token.children, state)