Content box color changes

[fmaussion]

Describe the bug

The color of the content boxes changed after upstream changes in the pydata theme: executablebooks/meta#168

Expected behavior

I think that book-theme needs to be more conservative than that and keep the colors as they were.

Additional context

@choldgraf suggest a fix along these lines: https://pydata-sphinx-theme.readthedocs.io/en/latest/user_guide/customizing.html#theme-variables

I'm not sure I'll have time to dig into this right away, so if someone knows how to do that please go ahead!

[choldgraf]

I think this is closed by #246 - @fmaussion wanna double check that the colors are correct now?

[fmaussion]

@choldgraf I just tested this and for me now all the boxes are grey

[choldgraf]

hmm that's weird, and you're on the latest pydata theme + sphinx book theme? they should look like the boxes here:

https://sphinx-book-theme.readthedocs.io/en/latest/reference/demo.html#admonitions

[fmaussion]

Ups sorry for the noise. I'm quite sure I was on latest but to be sure I deinstalled and reinstalled everything and now it works.

Thanks for checking!

[choldgraf]

hooray!

[pradyunsg]

@choldgraf Should we declare a minimum requirement on the pydata theme, now that we're depending on something that's only available in newer versions?

[choldgraf]

well we already do I think (~=0.4.1)...but we need to bump this again whenever the next version comes out. I actually jumped the gun a bit and I think this color box change may still be in master but not released, but I could be wrong. Basically I am confused.

[fmaussion]

Basically I am confused.

Same - It actually still does not work for me. I had to revert sphinx pydata to 0.4.1 to get my colors to work (while at latest for jupyter-book and sphinx-jupyter-book)

[choldgraf]

ok @fmaussion can you try this again on master? I think that #240 may fix this

[fmaussion]

Will do - do I need a specific version of pydata sphinx theme for that?

[fmaussion]

Oh I've seen you pinned 0.4.1 in #249

[choldgraf]

try it on master for both - that fix in #249 should not do anything on 0.4.1, and should provide correct colors on the new pydata version when it's released

[fmaussion]

[edited]

$ pip list
jupyter-book                      0.8.3
pydata-sphinx-theme               0.4.2.dev0
sphinx-book-theme                 0.0.39b1 

Results in something better, but not quite it:

(should be red)

(is OK)

(should be blue)

Also, the results I different wether I install latest sphinx-book-theme via pip install -e . on cloned master (the results above) or via pip install --upgrade git+https://github.com/executablebooks/sphinx-book-theme (different colors, also wrong).

This is all super confusing to me and I wonder if I should start from a fresh environment (although I can't really see what I'm doing wrong here).

Note also this problem that I have since I tried to upgrade too many things and can't recover from: executablebooks/sphinx-exercise#28

(sorry for the mess)

[fmaussion]

(sorry I edited my original post which was not in order)

[choldgraf]

ah darn - OK I think the problem is that the pydata theme also changed this behavior, will try to fix

[choldgraf]

ok I believe this is now resolved