Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ NEW: sphinx sidebars functionality #233

Merged
merged 4 commits into from
Oct 13, 2020

Conversation

choldgraf
Copy link
Member

@choldgraf choldgraf commented Oct 11, 2020

This changes our template to use Sphinx's html_sidebars functionality, which should make it a bit more extensible / not hard-coded. Theoretically it shouldn't change any of the default behavior or tests.

NOTE: this is a draft, for some reason I can't figure out how to mark it as-such after it's already been opened

@chrisjsewell
Copy link
Member

NOTE: this is a draft, for some reason I can't figure out how to mark it as-such after it's already been opened

👀
image

@choldgraf choldgraf marked this pull request as ready for review October 13, 2020 20:54
@choldgraf
Copy link
Member Author

ok I added in a little blog preview section to both demo the sidebar functionality in our docs, and also to get some CSS tweaks right. I think this is good to go! @chrisjsewell I'll make an alpha release for ya

@choldgraf choldgraf changed the title using sphinx sidebars ✨ NEW: sphinx sidebars functionality Oct 13, 2020
@choldgraf choldgraf merged commit 80cbb1b into executablebooks:master Oct 13, 2020
@choldgraf choldgraf deleted the sidebar-update branch October 13, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants