Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ ENH: Left sidebar drawer animation #298

Merged
merged 3 commits into from
Mar 1, 2021

Conversation

DrDrij
Copy link
Contributor

@DrDrij DrDrij commented Mar 1, 2021

This PR adds:

  • easing in-out horizontal animation for the left sidebar on desktop (replacing content squash animation)
  • left sidebar positioned over main content on browser windows <786px, also with ease in-out animation (replacing animate slide-from-top)

Tested on Safari 14.02, Chrome 88, Firefox 86.

@choldgraf
Copy link
Member

Argh this is running into that sphinxcontrib-bibtex bug which is stopping the RTD. So I pulled it locally to test it out and made a gif to show off the functionality:

rzO446a8Ag

This looks really excellent @DrDrij 🤩🤩🤩🤩 some serious CSS dark voodoo magic here, I have no idea how you do it haha.

@choldgraf
Copy link
Member

I just pushed another commit to this branch to try and update from master, which will pull in the PR that suppressed that warning

@choldgraf choldgraf changed the title Tidy left sidebar animation, drawer at <768px breakpoint #148 ✨ ENH: Left sidebar drawer animation Mar 1, 2021
@choldgraf choldgraf merged commit 76fe7e7 into executablebooks:master Mar 1, 2021
@choldgraf
Copy link
Member

OK CI now happy, so gonna merge this in, I tested on a few different widths and it seemed to work much better than the previous version. Thanks for this improvement ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants