Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 IMPROVE: add css to highlight searched for phrases #350

Merged

Conversation

sanjayankur31
Copy link
Contributor

Fixes: jupyter-book/jupyter-book#1244

Like other sphinx themes, this highlights phrases in search results.

Fixes: jupyter-book/jupyter-book#1244

Like other sphinx themes, this highlights phrases in search results.
@welcome
Copy link

welcome bot commented Jun 24, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@choldgraf
Copy link
Member

hey @sanjayankur31 - can you make sure to install pre-commit locally? It compiles the SCSS into a CSS file that's linked by the actual repo. That'll make sure it ends up in the package

@sanjayankur31
Copy link
Contributor Author

hey @sanjayankur31 - can you make sure to install pre-commit locally? It compiles the SCSS into a CSS file that's linked by the actual repo. That'll make sure it ends up in the package

Uh, sorry about that! Done it now.

@choldgraf choldgraf merged commit 2f64af1 into executablebooks:master Jun 25, 2021
@welcome
Copy link

welcome bot commented Jun 25, 2021

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@choldgraf
Copy link
Member

LGTM, thanks!

@sanjayankur31 sanjayankur31 deleted the feat/highlight-search-terms branch April 8, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

searched for terms are not highlighted on the target page
2 participants