-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] Add support for Python 3.11 #105
[MAINT] Add support for Python 3.11 #105
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
for more information, see https://pre-commit.ci
Does |
I went ahead and added support for Python <= 3.8. I think this is ready from my side. |
LGTM but I am not a maintainer.
It works. The reason your build fails is because of:
|
Co-authored-by: James McKinney <26463+jpmckinney@users.noreply.github.com>
Codecov ReportBase: 90.01% // Head: 89.97% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
- Coverage 90.01% 89.97% -0.04%
==========================================
Files 11 10 -1
Lines 941 938 -3
==========================================
- Hits 847 844 -3
Misses 94 94
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Thanks for the review and the clarifying comment @jpmckinney! I have made the changes you suggested. It would be great if someone with write access could approve and merge this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the extra 3.8 support, I added a comment to note when we can deprecate the extra check. I think the failing test is just because of codecov being broken!
importlib.resorces.open_text
has been deprecated in Python 3.11 in favor ofimportlib.resources.files
.sphinx-design
v0.3.0 doesn't work on Python 3.11:SciPy doc build log
This PR replaces all the uses of
importlib.resources.open_text
with the new interfaceimportlib.resources.files
. Does this need any tests?