-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for sphinx 7 and onwards #131
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
Actually all tests are passing on my fork 🎉 LecrisUT#1 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
=======================================
Coverage 89.97% 89.97%
=======================================
Files 11 11
Lines 948 948
=======================================
Hits 853 853
Misses 95 95
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@choldgraf in case you missed it and sorry for the ping if you are not the one I should have pinged :) |
sphinx conflicts with sphinx-design and we are waiting on: executablebooks/sphinx-design#131
Hello, hello! Any update on this? |
@chrisjsewell -- sorry for the ping, would it be possible to look at this PR to support Sphinx 7 in Thanks, |
superceded by #148 |
Closes #130