Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Improve specificity of JS function name #153

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

danirus
Copy link
Contributor

@danirus danirus commented Aug 14, 2023

This PR comes to fix a namespace issue when a Sphinx project uses both, sphinx-design and sphinx-inline-tabs. Both extensions have quite similar JavaScript functionality, sharing the name of the two functions (ready and onLabelClick). Given that the JavaScript modules (in both cases) are not protected within a namespace, when using sphinx-inline-tabs (I mean, using .. tab:: <label> from sphinx-inline-tabs) fails to work because sphinx-design's onLabelClick was loaded after and its onLabelClick overrides the same function from sphinx-inline-tabs. The code from sphinx-inline-tabs seems older, that's why I kindly submit the PR here. Thanks by the way for this great Sphinx extension.

@welcome
Copy link

welcome bot commented Aug 14, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@chrisjsewell chrisjsewell changed the title Fix namespace issue with sphinx-inline-tabs 👌 Improve specificity of JS function Aug 30, 2023
@chrisjsewell chrisjsewell changed the title 👌 Improve specificity of JS function 👌 Improve specificity of JS function name Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers

@chrisjsewell chrisjsewell merged commit c7a2ca9 into executablebooks:main Aug 30, 2023
15 checks passed
@welcome
Copy link

welcome bot commented Aug 30, 2023

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@danirus danirus deleted the fix-namespace-issue branch August 30, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants