-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ NEW: Add material design icons roles #41
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
for more information, see https://pre-commit.ci
I still have no idea what's wrong with the pytest for Myst icons-material-design.xml. I've tried using I'm not sure what is going on with the line that is triggering the sphinx-design/tests/test_snippets.py Line 102 in 629b868
|
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
==========================================
- Coverage 88.82% 88.29% -0.54%
==========================================
Files 10 10
Lines 859 914 +55
==========================================
+ Hits 763 807 +44
- Misses 96 107 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one cheers!
I may submit updates (via PR) to the compiled jsons when I see significant changes to the material icons repo. These updates may come without a linked issue though. |
Sounds good ta 👍 |
Just going through some of the other issues, then should have a release out soon |
Any idea about ETA for next release?I'm sorry this sounds impatient (there's really no need to rush), but I keep teasing this feature over on the sphinx-immaterial theme repo, so I'm very much looking forward to the next release. We're starting to consider an optional extra CSS that exports user-specified SVG's data (based on node.js pkgs - not google's src repo like this feature is) as CSS vars... |
No that's fair, sorry I got side-tracked with other things, but will try to get this done within the week |
resolves #36
This PR add 5 new roles for using Google's Material Design Icons as inline text. Each role represents a different material design "flavor":
material-regular
material-outlined
material-sharp
material-round
material-twotone
Amongst all these flavors, there is a total of 10662 new icons provided. Instead of displaying them all, I defer users to browse Goggle's Material Design Icons showcase.
Includes updates to
Since the feature is working with the JSON files I programmatically generated from the google/material-design-icons repo, I set up a small repo to run a CI job that updates JSON files when needed.